From 04421e7d4dc7bc1e2896bbf7d64cae3f0e7b1d3f Mon Sep 17 00:00:00 2001 From: Muhammad Wasif Ali Wasif <76695420+wachi35676@users.noreply.github.com> Date: Tue, 13 Oct 2026 21:43:59 +0500 Subject: [PATCH] fix(relinker): build the manifest resource in paths with spaces windres passes include directories to the preprocessor unquoted, so relinker.rc failed to compile when the checkout path contains a space. The resource is now an object library without the relinker's include directories. Co-Authored-By: Claude Opus 5.5 --- core/relinker/CMakeLists.txt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/core/relinker/CMakeLists.txt b/core/relinker/CMakeLists.txt index e670c9980..48698704c 100644 --- a/core/relinker/CMakeLists.txt +++ b/core/relinker/CMakeLists.txt @@ -116,8 +116,9 @@ if(BUILD_TESTING AND WIN32) endif() if(WIN32) - target_sources(relinker PRIVATE ${CMAKE_CURRENT_SOURCE_DIR}/relinker.rc) + add_library(relinker_resources OBJECT ${CMAKE_CURRENT_SOURCE_DIR}/relinker.rc) set_source_files_properties(${CMAKE_CURRENT_SOURCE_DIR}/relinker.rc PROPERTIES OBJECT_DEPENDS ${CMAKE_CURRENT_SOURCE_DIR}/relinker.manifest) + target_sources(relinker PRIVATE $) target_compile_options(relinker PRIVATE -municode) target_link_options(relinker PRIVATE -municode) endif()