From 7773bbcbf8da20694710e1dbf2a3cfa627c2c4c0 Mon Sep 17 00:00:00 2001 From: boykopovar Date: Sun, 13 Sep 2026 13:52:41 +0300 Subject: [PATCH] chore(sceVideoOut): throw ex instead of stubs --- core/libs/prx/libSceVideoOut/src/Buffer.cpp | 3 +++ core/libs/prx/libSceVideoOut/src/Output.cpp | 18 ++++++++---------- 2 files changed, 11 insertions(+), 10 deletions(-) diff --git a/core/libs/prx/libSceVideoOut/src/Buffer.cpp b/core/libs/prx/libSceVideoOut/src/Buffer.cpp index c4ed8d994..a133b59ba 100644 --- a/core/libs/prx/libSceVideoOut/src/Buffer.cpp +++ b/core/libs/prx/libSceVideoOut/src/Buffer.cpp @@ -127,6 +127,9 @@ int APS5_VABI sceVideoOutSubmitFlip(int handle, int index, int flipMode, int64_t if (flipMode < VIDEO_OUT_FLIP_MODE_VSYNC || flipMode > VIDEO_OUT_FLIP_MODE_VSYNC_MULTI) { return VIDEO_OUT_ERROR_INVALID_VALUE; } + if (flipMode != VIDEO_OUT_FLIP_MODE_VSYNC) { + throw std::runtime_error(std::string(__func__) + ": flip mode not implemented"); + } if (index < VIDEO_OUT_BUFFER_INDEX_BLACK || index >= VIDEO_OUT_BUFFER_NUM_MAX) { return VIDEO_OUT_ERROR_INVALID_INDEX; } diff --git a/core/libs/prx/libSceVideoOut/src/Output.cpp b/core/libs/prx/libSceVideoOut/src/Output.cpp index a62b4bb26..2179accaf 100644 --- a/core/libs/prx/libSceVideoOut/src/Output.cpp +++ b/core/libs/prx/libSceVideoOut/src/Output.cpp @@ -29,7 +29,9 @@ static int validateOutputConfig(int handle, uint64_t mode, const VideoOutOutputO extern "C" { int APS5_VABI sceVideoOutOpen(int userId, int busType, int index, const void* param) { - (void)param; + if (param != nullptr) { + throw std::runtime_error(std::string(__func__) + ": param not implemented"); + } if (userId != 255 && userId != 0) { return VIDEO_OUT_ERROR_INVALID_VALUE; } @@ -58,9 +60,7 @@ int APS5_VABI sceVideoOutSetFlipRate(int handle, int rate) { if (rate < 0 || rate > 2) { return VIDEO_OUT_ERROR_INVALID_VALUE; } - std::unique_lock lock(cfg->mutex); - cfg->flipRate = rate; - return 0; + throw std::runtime_error(std::string(__func__) + " not implemented"); } int APS5_VABI sceVideoOutGetFlipStatus(int handle, VideoOutFlipStatus* status) { @@ -169,14 +169,14 @@ int APS5_VABI sceVideoOutSetWindowModeMargins(int handle, int top, int bottom) { if (!VideoOutDriver::Get().IsOpen(handle)) { return VIDEO_OUT_ERROR_INVALID_HANDLE; } - return 0; + throw std::runtime_error(std::string(__func__) + " not implemented"); } int APS5_VABI sceVideoOutLatencyControlWaitBeforeInput(int handle) { if (!VideoOutDriver::Get().IsOpen(handle)) { return VIDEO_OUT_ERROR_INVALID_HANDLE; } - return 0; + throw std::runtime_error(std::string(__func__) + " not implemented"); } int APS5_VABI sceVideoOutLatencyMeasureSetStartPoint(int handle, uint32_t point) { @@ -184,7 +184,7 @@ int APS5_VABI sceVideoOutLatencyMeasureSetStartPoint(int handle, uint32_t point) if (!VideoOutDriver::Get().IsOpen(handle)) { return VIDEO_OUT_ERROR_INVALID_HANDLE; } - return 0; + throw std::runtime_error(std::string(__func__) + " not implemented"); } int APS5_VABI sceVideoOutColorSettingsSetGamma(VideoOutColorSettings* settings, float gamma) { @@ -206,9 +206,7 @@ int APS5_VABI sceVideoOutAdjustColor(int handle, const VideoOutColorSettings* se if (cfg == nullptr) { return VIDEO_OUT_ERROR_INVALID_HANDLE; } - std::unique_lock lock(cfg->mutex); - cfg->gamma = settings->gamma; - return 0; + throw std::runtime_error(std::string(__func__) + " not implemented"); } }