shifathosn
/
AnyPS5
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(shader): give 10_10_10_2 integer vertex inputs an integer type 

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This commit is contained in:
krishnaraya 2026-10-09 12:49:25 -04:00
parent d70b899894
commit dffd449489
2 changed files with 13 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
core/libs/prx/libSceAgcDriver/tests/Graphics.cpp
View File

@ -2527,6 +2527,17 @@ void validationTests() {
Require(AgcDriver::Graphics::DecodeVertexFormat(attribute).format == VK_FORMAT_A2B10G10R10_SINT_PACK32 && std::string_view(AgcDriver::Graphics::DecodeVertexFormat(attribute).scalar) == "i32", "2_10_10_10 sint vertex format was not decoded");
attribute.resource.fields[3] = 36u << 12u;
Require(AgcDriver::Graphics::DecodeVertexFormat(attribute).format == VK_FORMAT_B10G11R11_UFLOAT_PACK32, "10_11_11 float vertex format was not decoded");
for (std::uint32_t format = 1; format < 128u; ++format) {
attribute.resource.fields[3] = format << 12u;
std::string_view scalar;
try {
scalar = AgcDriver::Graphics::DecodeVertexFormat(attribute).scalar;
} catch (const std::exception&) {
continue;
}
const auto numeric = ShaderRecompiler::VertexInputNumericClass(static_cast<ShaderRecompiler::IrBufferFormat>(format));
Require((scalar == "u32") == (numeric == ShaderRecompiler::IrTextureNumericClass::Uint) && (scalar == "i32") == (numeric == ShaderRecompiler::IrTextureNumericClass::Sint), "vertex format " + std::to_string(format) + " declares a shader input of another numeric type than its attribute");
}
attribute.resource.fields[3] = 43u << 12u;
expectFailure([&] { AgcDriver::Graphics::DecodeVertexFormat(attribute); }, "unsupported vertex format");
attribute.resource.fields = {0x1000, 32u << 16u, 3, 77u << 12u};

2
core/shader/recompiler/RdnaDecoder/src/RdnaDescriptorFormat.cpp
View File

@ -144,6 +144,7 @@ IrTextureNumericClass VertexInputNumericClass(IrBufferFormat format) {
case IrBufferFormat::Format8_8UInt:
case IrBufferFormat::Format32UInt:
case IrBufferFormat::Format16_16UInt:
case IrBufferFormat::Format10_10_10_2UInt:
case IrBufferFormat::Format8_8_8_8UInt:
case IrBufferFormat::Format32_32UInt:
case IrBufferFormat::Format16_16_16_16UInt:
@ -154,6 +155,7 @@ IrTextureNumericClass VertexInputNumericClass(IrBufferFormat format) {
case IrBufferFormat::Format8_8SInt:
case IrBufferFormat::Format32SInt:
case IrBufferFormat::Format16_16SInt:
case IrBufferFormat::Format10_10_10_2SInt:
case IrBufferFormat::Format8_8_8_8SInt:
case IrBufferFormat::Format32_32SInt:
case IrBufferFormat::Format16_16_16_16SInt: