shifathosn
/
cadcraft
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Geometry: keep vector midpoints finite at coordinate extremes (#793)

This commit is contained in:
Jason Brashear 2026-10-13 03:36:51 -05:00 committed by GitHub
parent 14343212a9
commit 89c834155d
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 13 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
crates/geom/src/vec.rs
View File

@ -66,7 +66,7 @@ impl Vec2 {
self + (o - self) * t
}
pub fn mid(self, o: Vec2) -> Vec2 {
self.lerp(o, 0.5)
Vec2::new(self.x.midpoint(o.x), self.y.midpoint(o.y))
}
pub fn is_finite(self) -> bool {
self.x.is_finite() && self.y.is_finite()
@ -205,6 +205,18 @@ impl Neg for Vec3 {
mod tests {
use super::*;
#[test]
fn midpoint_handles_finite_coordinate_extremes() {
for (a, b, expected) in [
(Vec2::new(-1e308, 1e308), Vec2::new(1e308, -1e308), Vec2::ZERO),
(Vec2::new(1e308, -1e308), Vec2::new(1.6e308, -1.6e308), Vec2::new(1.3e308, -1.3e308)),
(Vec2::new(f64::from_bits(1), 0.0), Vec2::new(f64::from_bits(1), 0.0), Vec2::new(f64::from_bits(1), 0.0)),
] {
assert_eq!(a.mid(b), expected);
assert_eq!(b.mid(a), expected);
}
}
#[test]
fn near_uses_finite_nonnegative_tolerance_without_squaring() {
let origin = Vec2::ZERO;