747e579d97
Logging: Change the TimeStretch::Process log from debug to trace level.
...
This function is called too many times and makes the debug logging basically unusable due to the spam.
2018-09-20 22:33:54 -05:00
e27a1af5f7
time_stretch: Remove unused <array> include
...
This isn't used within this header and isn't necessary.
2018-09-17 15:08:34 -04:00
184f8e72b0
stream: Replace includes with forward declarations where applicable
...
Avoids propagating includes in headers where it's not necessary to do
so.
2018-09-17 15:08:34 -04:00
01a14e4bdf
audio_renderer: Replace includes with forward declarations where applicable
...
Avoids including unnecessary headers within the audio_renderer.h header,
lessening the likelihood of needing to rebuild source files including
this header if they ever change.
Given std::vector allows forward declaring contained types, we can move
VoiceState to the cpp file and hide the implementation entirely.
2018-09-17 15:08:30 -04:00
d6c188f19d
Merge pull request #1314 from lioncash/cast
...
audio_core/time_stretch: Silence truncation warnings in Process()
2018-09-17 12:28:19 -04:00
5647c5bb75
Merge pull request #1321 from lioncash/audio-shadow
...
cubeb_sink: Get rid of variable shadowing within CubebSink's constructor
2018-09-17 12:26:29 -04:00
9b4cc24f0f
Merge pull request #1320 from lioncash/name
...
cubeb_sink: Correct context name in ListCubebSinkDevices()
2018-09-17 10:10:33 -04:00
1190ea6ddb
Port #4182 from Citra: "Prefix all size_t with std::"
2018-09-15 15:21:06 +02:00
7c7c12f664
cubeb_sink: Get rid of variable shadowing within CubebSink's constructor
...
The parameter of the lambda was shadowing the variable that was being
assigned to.
2018-09-14 12:20:51 -04:00
514f8f036c
cubeb_sink: Correct context name in ListCubebSinkDevices()
...
This ain't Citra.
2018-09-14 12:18:09 -04:00
a51b67f163
audio_core/time_stretch: Silence truncation warnings in Process()
...
The SoundTouch API only accepts uint amount of samples.
2018-09-13 19:50:01 -04:00
e228fcd133
Merge pull request #1298 from lioncash/view
...
audio_core/sink_details: Change std::string parameter into std::string_view
2018-09-12 18:24:57 -04:00
f5b02a99e7
Merge pull request #1163 from FearlessTobi/add-audio-stretching
...
audio_core: Add audio stretching support
2018-09-12 18:23:54 -04:00
9ffbfeee26
audio_core: Flush stream when not playing anything
2018-09-12 18:09:14 +01:00
93e3030d0c
audio_core/sink_details: Change std::string parameter into std::string_view
...
The given string is only ever used for lookup and comparison, so we can
just utilize a non-owning view to string data here
2018-09-11 21:36:12 -04:00
84b7a67ef1
cubeb_sink: Downsample arbitrary number of channels
2018-09-09 09:51:46 +01:00
d7d7fec6c7
cubeb_sink: Perform audio stretching
2018-09-08 18:56:38 +01:00
4e439efbf6
audio_core: Add audio stretcher
2018-09-08 18:56:38 +01:00
722441ef0b
cubeb_sink: Hold last available value instead of writing zeros
...
This reduces clicking in output audio should we underrun.
2018-09-08 18:56:38 +01:00
d99dceeb7a
cubeb_sink: Use RingBuffer
2018-09-08 18:56:38 +01:00
7377afca3a
Add audio stretching support
2018-09-08 18:26:23 +01:00
ed0dc20280
audio_renderer: Rename AudioOut instance to audio_out
2018-09-08 16:50:12 +01:00
71250d28d6
Update microprofile scopes.
...
Blame the subsystems which deserve the blame :)
The updated list is not complete, just the ones I've spotted on random sampling the stack trace.
2018-09-04 11:04:26 +02:00
a6c2e1e95c
audio_core/filter: Add explicit cast to assignment in Process()
...
Previously this would cause warnings about implicit conversions to s16
from a double
2018-08-21 12:32:37 -04:00
4f12aba993
Merge pull request #1033 from MerryMage/interp
...
audio_core: Interpolate
2018-08-13 12:19:59 -04:00
26aa4ae7a8
audio_renderer: samples_remaining counts frames, not samples
2018-08-13 11:26:50 +01:00
0525998743
audio_core: Interpolate
2018-08-13 11:26:50 +01:00
fea4df74c2
audio_core: Implement low-pass filter
2018-08-13 11:26:50 +01:00
c9923e03bb
cubeb_sink: Protect queue with a mutex
2018-08-12 20:41:46 +01:00
7d49bcdb1b
Pushed the requested sample rate instead of our fixed sample rate
2018-08-12 14:58:36 +10:00
f3ef58207e
Added GetAudioRendererSampleRate, GetAudioRendererSampleCount & GetAudioRendererMixBufferCount
...
GetAudioRendererSampleRate is set as a "STUB" as a game could check if the sample rate it sent and the sample rate it wants don't match. Just a thought of something which could happen so keeping it as stub for the mean time
2018-08-12 14:46:12 +10:00
fef6c33e77
Make building cubeb optional
2018-08-07 13:21:56 +02:00
5904aa20ce
audio_core: Implement audren_u audio playback.
2018-08-04 21:54:30 -04:00
600e4bbeac
audio_core: Use s16 where possible for audio samples.
2018-08-04 18:22:58 -04:00
7688b83a1c
audio_core: Port codec code from Citra for ADPCM decoding.
2018-08-04 18:22:58 -04:00
950de5fd73
cubeb_sink: Support variable sample_rate and num_channels.
2018-08-04 15:30:10 -04:00
97647e60f2
audio_core: Sinks need unique names as well.
2018-08-04 14:34:12 -04:00
7186882bfe
audio_core: Streams need unique names for CoreTiming.
2018-08-04 14:34:12 -04:00
1028560b4c
Merge pull request #895 from lioncash/sink
...
sink_details: std::move std::function instances
2018-08-03 11:00:56 -04:00
07a3c8a2a5
audio_out: Use Buffer::Tag alias in GetTagsAndReleaseBuffers()'s prototype
...
This makes the Buffer::Tag usage consistent with the Stream class's
prototype of GetTagsAndReleaseBuffers().
2018-08-02 05:18:32 -04:00
881380bc97
sink_details: Deduplicate long std::function repetition
...
We can just use type aliases to avoid needing to write the same long
type twice
2018-08-01 23:56:02 -04:00
5061e89fd1
sink_details: std::move std::function instances
...
Given std::function is allowed to potentially allocate, these should be
std::move'd to prevent potential reallocation (should that ever happen).
2018-08-01 23:50:48 -04:00
14d9b2d6d3
audio_core: Add configuration settings.
2018-07-31 22:38:42 -04:00
0ba0cdbed9
audio_core: Implement Sink and SinkStream interfaces with cubeb.
2018-07-30 21:45:24 -04:00
f1f3a65391
audio_core: Add interfaces for Sink and SinkStream.
2018-07-30 21:45:24 -04:00
02472448da
audio_core: Misc. improvements to stream/buffer/audio_out.
2018-07-30 18:58:40 -04:00
fa8e381b3e
audio_core: Add initial code for keeping track of audout state.
2018-07-27 22:33:31 -04:00
5dbd091a80
Massive removal of unused modules
2018-01-12 19:11:03 -07:00
1b2aa3780d
CoreTiming: Reworked CoreTiming (cherry-picked from Citra #3119 )
...
* CoreTiming: New CoreTiming; Add Test for CoreTiming
2018-01-08 19:10:25 -05:00
9b8fff5568
audio: Log dropping frames as trace to reduce spam.
2018-01-07 16:52:59 -05:00
da1c8d1522
Fixed type conversion ambiguity
2017-09-30 09:34:35 +01:00
3532957099
Audio: Use std::deque instead of std::vector for the audio buffer type (StereoBuffer16).
...
The current code inserts and deletes elements from the beginning of the audio buffer, which is very inefficient in an std::vector.
Profiling was done using VisualStudio2017's Performance Analyzer in Super Mario 3D Land.
Before this change: AudioInterp::Linear had 14.14% of the runtime (inclusive) and most of that time was spent in std::vector's insert implementation.
After this change: AudioInterp::Linear has 0.36% of the runtime (inclusive)
2017-09-25 18:31:37 -05:00
cbb31422b7
interpolate: Interpolate on a frame-by-frame basis
2017-08-28 10:54:41 +01:00
f9a960614d
CMake: Add SoundTouch include path to target property
2017-05-27 22:09:28 -07:00
d84915c4a1
CMake: Define an interface target for SDL2 definitions
2017-05-27 21:38:49 -07:00
b78ce2bce5
CMake: Correct inter-module dependencies and library visibility
...
Modules didn't correctly define their dependencies before, which relied
on the frontends implicitly including every module for linking to
succeed.
Also changed every target_link_libraries call to specify visibility of
dependencies to avoid leaking definitions to dependents when not
necessary.
2017-05-27 18:41:24 -07:00
03ad0ec0e5
DSP: Create backing memory for entire DSP RAM
...
Also move address space mapping out of video_core.
2017-05-09 21:44:00 -07:00
dc1927a9d1
Doxygen: Amend minor issues ( #2593 )
...
Corrects a few issues with regards to Doxygen documentation, for example:
- Incorrect parameter referencing.
- Missing @param tags.
- Typos in @param tags.
and a few minor other issues.
2017-02-26 17:58:51 -08:00
38dfe42ad9
Support looping HLE audio ( #2422 )
...
* Support looping HLE audio
* DSP: Fix dirty bit clears, handle nonmonotonically incrementing IDs
* DSP: Add start offset support
2017-01-29 23:52:25 -08:00
0adb56a6b2
fixed the override warning
...
```
In file included from citra/src/audio_core/sink_details.cpp:11:
citra/src/./audio_core/sdl2_sink.h:25:10: warning: 'SetDevice' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
void SetDevice(int device_id);
^
citra/src/./audio_core/sink.h:39:18: note: overridden virtual function is here
virtual void SetDevice(int device_id) = 0;
^
```
2017-01-27 14:24:14 -06:00
637f58dd1e
SDL: Select audio device ( #2403 )
...
* Initial Commit
Added Device logic to Sinks
Started on UI for selecting devices
Removed redundant import
* Audio Core: Complete Device Switching
Complete the device switching implementation by allowing the output
device to be loaded, changed and saved through the configurations menu.
Worked with the Sink abstraction and tuned the "Device Selection"
configuration so that the Device List is automatically populated when
the Sink is changed.
This hopefully addresses the concerns and recommendations mentioned in
the comments of the PR.
* Clean original implementation.
* Refactor GetSinkDetails
2017-01-25 22:33:26 -05:00
dc6a23e0f6
time_stretch: Add missing #pragma once directive
2016-12-12 19:16:46 -05:00
b0ebdfae34
Add all services to the Service namespace
...
Previously there was a split where some of the services were in the
Service namespace and others were not.
2016-12-11 00:07:27 +00:00
b5cfe1d2f4
audio_core: SelectSink should default to auto if sink_id is invalid
2016-12-10 01:26:22 +00:00
f5b928c330
Improve verbosity of audio errors with SDL_GetError()
2016-11-22 17:28:11 +01:00
07fdcf150d
Fix typos
2016-10-20 12:26:59 -02:00
fa5d9d8266
Use negative priorities to avoid special-casing the self-include
2016-09-21 00:15:56 -07:00
1138ec0d49
Remove empty newlines in #include blocks.
...
This makes clang-format useful on those.
Also add a bunch of forgotten transitive includes, which otherwise
prevented compilation.
2016-09-21 11:15:47 +09:00
1e4a5da9f4
Manually tweak source formatting and then re-run clang-format
2016-09-18 21:14:25 -07:00
628ed4376a
Sources: Run clang-format on everything.
2016-09-18 09:38:01 +09:00
de4fa45fb5
audio_core: Tweak audio latency
2016-09-07 15:27:32 +01:00
61bde9974b
codec: Fix ADPCM distortion caused by incorrect nibble order
...
Closes #2049 .
Signed-off-by: MerryMage <MerryMage@users.noreply.github.com>
2016-09-03 14:06:25 +01:00
96febf8f85
audio_core: Add EnableStretching to interface so that one can toggle stretching on and off
2016-08-31 16:56:30 +01:00
559ca8ae8a
sink: Change EnqueueSamples to take a pointer to a buffer instead of a std::vector
2016-08-31 16:55:10 +01:00
ba0f27c797
DSP/HLE: Audio output
2016-05-19 07:25:26 +01:00
8a1bd3ee7a
DSP/HLE: Implement mixer processing
2016-05-19 07:24:39 +01:00
be941f1ecf
AudioCore: Implement time stretcher ( #1737 )
...
* AudioCore: Implement time stretcher
* fixup! AudioCore: Implement time stretcher
* fixup! fixup! AudioCore: Implement time stretcher
* fixup! fixup! fixup! AudioCore: Implement time stretcher
* fixup! fixup! fixup! fixup! AudioCore: Implement time stretcher
* fixup! fixup! fixup! fixup! fixup! AudioCore: Implement time stretcher
2016-05-14 22:04:03 -04:00
bb6bae806e
source: Fix missing logging arguments
...
Silences two warnings on OSX.
2016-05-09 09:41:03 -04:00
17e9bc5392
fixup simple type conversions where possible
2016-05-07 11:41:55 -04:00
8417518330
Merge pull request #1736 from MerryMage/sdl2-sink
...
AudioCore: SDL2 Sink
2016-05-07 11:08:13 -04:00
638de286c2
AudioCore: SDL2 Sink
2016-05-07 11:32:48 +01:00
bc76985937
HLE: Fix recent DSP change for Visual Studio.
2016-05-07 00:54:31 -04:00
f0cc8dc9ed
DSP/HLE: Implement Source processing
2016-05-03 20:58:28 +01:00
aa47fc2406
Audio: Add sink selection to configuration files
2016-04-30 07:41:02 +01:00
80c798dec3
AudioCore: List of sink types
2016-04-30 07:39:48 +01:00
3e940fcc96
AudioCore: Implement NullSink
2016-04-30 07:39:37 +01:00
6b9d36abb1
Merge pull request #1726 from MerryMage/read-write-region
...
AudioCore: CurrentRegion() -> ReadRegion(), WriteRegion()
2016-04-29 12:18:26 -04:00
1e19d9c579
AudioCore: CurrentRegion() -> ReadRegion(), WriteRegion()
2016-04-29 16:32:29 +01:00
e956bff1f4
Merge pull request #1723 from MerryMage/audio-interp
...
AudioCore: Implement interpolation
2016-04-29 10:43:20 -04:00
653ca59147
AudioCore: Implement interpolation
2016-04-29 08:05:41 +01:00
02427a978b
Merge pull request #1727 from MerryMage/minor-commit
...
AudioCore: Move samples_per_frame and num_sources into hle/common.h
2016-04-28 09:47:08 -04:00
1a1665c4f4
Merge pull request #1722 from MerryMage/soundtouch
...
Externals: Add soundtouch
2016-04-28 09:45:15 -04:00
2d50954f85
Externals: Add soundtouch
2016-04-28 13:33:14 +01:00
89e1019dc8
AudioCore: Move samples_per_frame and num_sources into hle/common.h
2016-04-28 11:22:40 +01:00
c622bea535
AudioCore: Hack to prevent regressions: Trigger Binary pipe interrupt every audio frame
2016-04-27 06:35:10 +01:00
4827a1bff7
DSP_DSP: Updated interrupt implementation
2016-04-27 06:35:06 +01:00
60ad3dcbcb
DSP/Pipe: There are 8 pipes
2016-04-25 07:50:53 +01:00
66ae4cddb5
DSP: Implement audio filters (simple, biquad)
2016-03-28 15:51:00 +01:00
f9d22fe9b5
DSP: Implement audio codecs (PCM8, PCM16, ADPCM)
2016-03-24 03:46:59 +00:00
447d9a5677
DSP: Implement Pipe 2
...
Pipe 2 is a DSP pipe that is used to initialize both the DSP hardware (the
application signals to the DSP to initialize) and the application (the DSP
provides the memory location of structures in the shared memory region).
2016-03-06 21:25:44 +00:00
Subv
Lioncash
bunnei
fearlessTobi
MerryMage
Markus Wick
David Marcec
KAMiKAZOW
James Rowe
B3n30
Huw Pascoe
Yuri Kunde Schlesner
Jake Merdich
noah the goodra
Kloen Lansfiel
freiro
Ricardo de Almeida Gonzaga
Emmanuel Gil Peyrot
fincs
Alexander Laties