From 01701193c44a3c2bb7a522fc5b564f04e645bffe Mon Sep 17 00:00:00 2001 From: Brandon Thomas Date: Sat, 3 Oct 2026 02:51:56 -0400 Subject: [PATCH] M7.7: merge fixes (Exposure param path, remaining stubs list, effects doc) Co-Authored-By: Claude Opus 5.5 --- crates/engine/src/tests_color_view.rs | 2 +- crates/engine/src/tests_stubs.rs | 2 +- docs/effects.md | 13 +++++++------ 3 files changed, 9 insertions(+), 8 deletions(-) diff --git a/crates/engine/src/tests_color_view.rs b/crates/engine/src/tests_color_view.rs index 316d2e5a..c0f83d66 100644 --- a/crates/engine/src/tests_color_view.rs +++ b/crates/engine/src/tests_color_view.rs @@ -155,7 +155,7 @@ fn color_engine_aces_working_spaces_and_hdr() { s.execute("layer.newSolid", json!({"color": "#ffffff", "width": 64, "height": 48})).unwrap(); let lid = s.active_comp().unwrap().layers[0].id.0; s.execute("effect.apply", json!({"layers": [lid], "effect": "Exposure"})).unwrap(); - s.execute("prop.set", json!({"layer": lid, "path": "effects/#1/exposure", "value": 2.0})).unwrap(); + s.execute("prop.set", json!({"layer": lid, "path": "effects/#1/master/exposure", "value": 2.0})).unwrap(); let mapped = s.render(cid, Tick::ZERO, RenderOpts::default()).data[0]; assert!(mapped[0] > 0.5 && mapped[0] < 0.99, "tone mapped: {mapped:?}"); s.execute("file.projectSettings", json!({"hdr": "clip"})).unwrap(); diff --git a/crates/engine/src/tests_stubs.rs b/crates/engine/src/tests_stubs.rs index b1525969..997552bc 100644 --- a/crates/engine/src/tests_stubs.rs +++ b/crates/engine/src/tests_stubs.rs @@ -332,7 +332,7 @@ fn implemented_stubs_are_enabled_and_workspaces_are_frontend() { assert!(s.drain_events().iter().any(|e| matches!(e, Event::Frontend { command, .. } if command == id))); } // What remains a stub is still disabled. - for id in ["view.displayColorManagement", "keys.audioToKeyframes"] { + for id in ["layer.autoTrace", "keys.audioToKeyframes"] { assert!(!s.is_enabled(id), "{id}"); } } diff --git a/docs/effects.md b/docs/effects.md index 75d32478..a7717d75 100644 --- a/docs/effects.md +++ b/docs/effects.md @@ -3,11 +3,11 @@ -EffectCraft ships 303 effects with 2434 parameters in total, grouped into the same categories as the Effects & Presets panel. Every effect is our own implementation, written from public behaviour descriptions and standard image-processing literature. Parameter names, order, popup options, units, defaults and ranges follow the reference application so that projects, expressions and muscle memory carry over. +EffectCraft ships 304 effects with 2446 parameters in total, grouped into the same categories as the Effects & Presets panel. Every effect is our own implementation, written from public behaviour descriptions and standard image-processing literature. Parameter names, order, popup options, units, defaults and ranges follow the reference application so that projects, expressions and muscle memory carry over. -- **GPU**: 24 effects also run on the GPU compositor with identical results. -- **32**: 303 effects process 32-bit float (HDR, overbright) pixels without clamping. -- **Status**: 261 implemented in full, 42 partial (what is missing is listed). +- **GPU**: 25 effects also run on the GPU compositor with identical results. +- **32**: 304 effects process 32-bit float (HDR, overbright) pixels without clamping. +- **Status**: 262 implemented in full, 42 partial (what is missing is listed). Effects are addressed by id (`ec..`) or display name in commands, scripts and the control channel, and every parameter by its id (`effects/#1/blurriness`). @@ -113,8 +113,8 @@ Effects are addressed by id (`ec..`) or display name in commands | Levels (Individual Controls) | `ec.color.levelsic` | 27 | | 32 | Implemented | | Lumetri Color | `ec.color.lumetri` | 38 | | 32 | Partial: no HSL Secondary, hue/saturation curves, HDR mode or look files | | OCIO CDL Transform | `ec.color.ociocdl` | 12 | | 32 | Implemented | -| OCIO Color Space Transform | `ec.color.ociocolorspace` | 4 | | 32 | Implemented | -| OCIO Display Transform | `ec.color.ociodisplay` | 5 | | 32 | Implemented | +| OCIO Color Space Transform | `ec.color.ociocolorspace` | 7 | | 32 | Implemented | +| OCIO Display Transform | `ec.color.ociodisplay` | 9 | | 32 | Implemented | | OCIO File Transform | `ec.color.ociofile` | 4 | | 32 | Implemented | | OCIO Look Transform | `ec.color.ociolook` | 6 | | 32 | Implemented | | PS Arbitrary Map | `ec.color.psarbitrarymap` | 2 | | 32 | Implemented | @@ -182,6 +182,7 @@ Effects are addressed by id (`ec..`) or display name in commands | Layer Control | `ec.control.layer` | 1 | GPU | 32 | Implemented | | Point Control | `ec.control.point` | 1 | GPU | 32 | Implemented | | Slider Control | `ec.control.slider` | 1 | GPU | 32 | Implemented | +| Stereo 3D Controls | `ec.control.stereo3d` | 5 | GPU | 32 | Implemented | ## Generate