From 63a7483a48a34db9413db093c7db177dc783852a Mon Sep 17 00:00:00 2001 From: bflatastic Date: Wed, 7 Oct 2026 02:34:14 +0700 Subject: [PATCH] Comments: describe the new drop, angle and cache code without product names Co-Authored-By: Claude Opus 5.5 --- crates/ui-egui/src/frames.rs | 6 +++--- crates/ui-egui/src/panels/fx_widgets.rs | 2 +- crates/ui-egui/src/panels/timeline.rs | 2 +- crates/ui-egui/src/panels/viewer_drop.rs | 2 +- crates/ui-egui/tests/ui_drag_drop.rs | 2 +- 5 files changed, 7 insertions(+), 7 deletions(-) diff --git a/crates/ui-egui/src/frames.rs b/crates/ui-egui/src/frames.rs index 765fac9a..6d14f66f 100644 --- a/crates/ui-egui/src/frames.rs +++ b/crates/ui-egui/src/frames.rs @@ -4,9 +4,9 @@ //! never waits for the compositor. Results land in a memory-budgeted cache keyed by the comp's //! *content* ([`comp_content`]: the comp and everything it uses), frame, scale, view and render //! options; the timeline draws the cached range as the green cache bar. An edit keeps the frames -//! of every comp it doesn't touch, and undo finds the frames of the state it returns to, as in -//! After Effects. Switches that don't change pixels (Audio, Lock, Shy, Hide Shy Layers) keep -//! the frames too. When the budget is full the least recently shown frames go first. +//! of every comp it doesn't touch, and undo finds the frames of the state it returns to. +//! Switches that don't change pixels (Audio, Lock, Shy, Hide Shy Layers) keep the frames too. +//! When the budget is full the least recently shown frames go first. //! //! wasm32 has no threads: jobs wait in the same priority queue and [`Frames::pump`] hands them //! to a [`RemoteFrames`] (the browser's frame worker, a second engine instance fed with project diff --git a/crates/ui-egui/src/panels/fx_widgets.rs b/crates/ui-egui/src/panels/fx_widgets.rs index a8fb2074..644e64bc 100644 --- a/crates/ui-egui/src/panels/fx_widgets.rs +++ b/crates/ui-egui/src/panels/fx_widgets.rs @@ -41,7 +41,7 @@ pub fn parse_angle(s: &str) -> Option { s.parse().ok() } -/// After Effects' angle value, `0x+45.0°`, at `at` (top left): the revolutions and the degrees +/// An angle value, `0x+45.0°`, at `at` (top left): the revolutions and the degrees /// are hot numbers of their own (drag to scrub, click to type) and changing one keeps the other. /// Returns the revolutions' rect, the degrees' rect and the new angle when either changed. pub fn angle_field(ui: &mut egui::Ui, at: Pos2, id: egui::Id, v: f64, decimals: usize, t: &Tokens) -> (Rect, Rect, Option) { diff --git a/crates/ui-egui/src/panels/timeline.rs b/crates/ui-egui/src/panels/timeline.rs index 0100cb26..3fbea99a 100644 --- a/crates/ui-egui/src/panels/timeline.rs +++ b/crates/ui-egui/src/panels/timeline.rs @@ -2311,7 +2311,7 @@ pub fn show(app: &mut EffectcraftApp, ui: &mut egui::Ui, rect: Rect) { // Drop targets: effects from Effects & Presets go on the layer under the pointer. Footage and // comps from the Project panel and files from the Media Browser go where they are dropped: a // line shows the place in the stack, and over the time graph a marker shows the In point too - // (Shift: at the current time), as in After Effects. + // (Shift: at the current time). if let Some(payload) = egui::DragAndDrop::payload::(&ctx) && !matches!(*payload, crate::panels::DragPayload::Property { .. }) && let Some(ptr) = ctx.input(|i| i.pointer.hover_pos()).filter(|_| ui.rect_contains_pointer(rows_rect)) diff --git a/crates/ui-egui/src/panels/viewer_drop.rs b/crates/ui-egui/src/panels/viewer_drop.rs index eeb50cca..31d426b3 100644 --- a/crates/ui-egui/src/panels/viewer_drop.rs +++ b/crates/ui-egui/src/panels/viewer_drop.rs @@ -1,4 +1,4 @@ -//! Dropping onto the Composition viewer, as in After Effects: footage, comps and solids from the +//! Dropping onto the Composition viewer: footage, comps and solids from the //! Project panel and files from the Media Browser become layers centred where they are dropped //! (#85), and an effect from Effects & Presets goes on the layer under the pointer, outlined //! while it is dragged (#88). Agents do the same with `layer.addItem {position}`, diff --git a/crates/ui-egui/tests/ui_drag_drop.rs b/crates/ui-egui/tests/ui_drag_drop.rs index 1e25bf1b..0fcdcd19 100644 --- a/crates/ui-egui/tests/ui_drag_drop.rs +++ b/crates/ui-egui/tests/ui_drag_drop.rs @@ -1,4 +1,4 @@ -//! Drag and drop between panels (egui_kittest, real pointer drags), as in After Effects: Project +//! Drag and drop between panels (egui_kittest, real pointer drags): Project //! items land in the Timeline where they are dropped, between layers and, over the time graph, //! starting there (#89); dropped on the Composition viewer they are centred where they land //! (#85); an effect dropped on the viewer goes on the layer under the pointer (#88).