From 8b8a57780f5b669d66ff68841547824042c30081 Mon Sep 17 00:00:00 2001 From: tylerjenningsw Date: Fri, 9 Oct 2026 13:51:44 -0400 Subject: [PATCH] Packaging: Windows upgrades and repairs install into the existing folder (#466) The MSI records its folder as the App Paths "Path" value of effectcraft.exe and reads it back with a registry search, so an upgrade, a repair or a silent reinstall goes where the installed copy already is. A folder passed on the command line (INSTALLFOLDER=...) still wins, and INSTALLFOLDER is Secure so a folder chosen in the UI reaches the elevated install. v0.6.0 and earlier have no Path value and upgrade in Program Files, where they are. --- packaging/windows/effectcraft.wxs | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/packaging/windows/effectcraft.wxs b/packaging/windows/effectcraft.wxs index 5a70002b..ae1fd194 100644 --- a/packaging/windows/effectcraft.wxs +++ b/packaging/windows/effectcraft.wxs @@ -4,7 +4,7 @@ wix build effectcraft.wxs -arch x64 -d Version=1.2.3 -d BinDir=... -d IconPath=... -o out.msi - Per-machine install into Program Files, a Start Menu shortcut, `.pcraft` owned by EffectCraft, + Per-machine install into Program Files (or a folder the user picks), a Start Menu shortcut, `.pcraft` owned by EffectCraft, and EffectCraft offered under "Open with" for PSD/PSB and the image formats it reads (without taking over the user's default app for them). --> @@ -30,6 +30,16 @@ + + + + + + + @@ -50,6 +60,7 @@ +