From 2ded7bf19333492e869442784475083e814c4c00 Mon Sep 17 00:00:00 2001
From: nihilist-narwhal <240798405+nihilist-narwhal@users.noreply.github.com>
Date: Sat, 10 Oct 2026 01:39:01 -0500
Subject: [PATCH] XLSX: write the _xlfn. prefix for GROUPBY, PIVOTBY, ENCODEURL
 and the REGEX functions

These were missing from the list of functions newer than the original
file format, so they were saved without the prefix, and Excel shows
#NAME? for such formulas.
---
 crates/xlsx/src/fmla.rs   | 2 ++
 crates/xlsx/src/tables.rs | 6 ++++++
 2 files changed, 8 insertions(+)

diff --git a/crates/xlsx/src/fmla.rs b/crates/xlsx/src/fmla.rs
index 9ac4ccf..c483414 100644
--- a/crates/xlsx/src/fmla.rs
+++ b/crates/xlsx/src/fmla.rs
@@ -132,6 +132,8 @@ mod tests {
         assert_eq!(to_file(&Formula::new("FILTER(A1:A3,B1:B3)")), "_xlfn._xlws.FILTER(A1:A3,B1:B3)");
         assert_eq!(from_file("_xlfn.XLOOKUP(1,A:A,B:B)"), "XLOOKUP(1,A:A,B:B)");
         assert_eq!(text_to_file("=IFS(A1>0,1)"), "_xlfn.IFS(A1>0,1)");
+        assert_eq!(to_file(&Formula::new("REGEXTEST(A1,\"x\")&ENCODEURL(B1)")), "_xlfn.REGEXTEST(A1,\"x\")&_xlfn.ENCODEURL(B1)");
+        assert_eq!(to_file(&Formula::new("GROUPBY(A1:A3,B1:B3,\"SUM\")")), "_xlfn.GROUPBY(A1:A3,B1:B3,\"SUM\")");
     }
 
     #[test]
diff --git a/crates/xlsx/src/tables.rs b/crates/xlsx/src/tables.rs
index 2d63dec..fe7cbdc 100644
--- a/crates/xlsx/src/tables.rs
+++ b/crates/xlsx/src/tables.rs
@@ -133,6 +133,7 @@ const FUTURE_FUNCTIONS: &[&str] = &[
     "DAYS",
     "DECIMAL",
     "DROP",
+    "ENCODEURL",
     "ERF.PRECISE",
     "ERFC.PRECISE",
     "EXPAND",
@@ -157,6 +158,7 @@ const FUTURE_FUNCTIONS: &[&str] = &[
     "GAMMA.INV",
     "GAMMALN.PRECISE",
     "GAUSS",
+    "GROUPBY",
     "HSTACK",
     "HYPGEOM.DIST",
     "IFNA",
@@ -199,6 +201,7 @@ const FUTURE_FUNCTIONS: &[&str] = &[
     "PERCENTRANK.INC",
     "PERMUTATIONA",
     "PHI",
+    "PIVOTBY",
     "POISSON.DIST",
     "QUARTILE.EXC",
     "QUARTILE.INC",
@@ -206,6 +209,9 @@ const FUTURE_FUNCTIONS: &[&str] = &[
     "RANK.AVG",
     "RANK.EQ",
     "REDUCE",
+    "REGEXEXTRACT",
+    "REGEXREPLACE",
+    "REGEXTEST",
     "RRI",
     "SCAN",
     "SEC",