diff --git a/.github/workflows/packaging-lint.yml b/.github/workflows/packaging-lint.yml
index 0e2388a6..ed2d8f00 100644
--- a/.github/workflows/packaging-lint.yml
+++ b/.github/workflows/packaging-lint.yml
@@ -51,6 +51,11 @@ jobs:
if grep -oE '' 'Value="InstallDirDlg"' '' \
+ 'Key="Software\LightCraft" Name="InstallFolder"' 'Value="LaunchLightcraft"'; do
+ grep -qF "$want" packaging/windows/lightcraft.wxs || { echo "::error::lightcraft.wxs lost: $want"; exit 1; }
+ done
desktop-file-validate packaging/linux/ai.storyteller.lightcraft.desktop
sed -e 's/@VERSION@/0.0.0/' -e 's/@DATE@/2026-01-01/' packaging/linux/ai.storyteller.lightcraft.metainfo.xml.in >"$RUNNER_TEMP/ai.storyteller.lightcraft.metainfo.xml"
appstreamcli validate --no-net --explain "$RUNNER_TEMP/ai.storyteller.lightcraft.metainfo.xml"
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
index b9c3a1ea..698d785b 100644
--- a/.github/workflows/release.yml
+++ b/.github/workflows/release.yml
@@ -147,6 +147,7 @@ jobs:
if: inputs.version != ''
shell: bash
run: cargo xtask version set "$LIGHTCRAFT_VERSION"
+ # package.ps1 adds the matching WixToolset.UI/Util.wixext (5.0.2) to the global extension cache.
- name: Install WiX
shell: pwsh
run: dotnet tool install --global wix --version 5.0.2
diff --git a/README.md b/README.md
index ffc80bc8..7ff53ba0 100644
--- a/README.md
+++ b/README.md
@@ -445,7 +445,9 @@ Questions, ideas or a bug you'd like to talk through first? Bring them to [Disco
| arm64 (Snapdragon and other ARM PCs) | `lightcraft--windows-arm64.msi` | `lightcraft--windows-arm64-portable.zip` |
| x86 (32-bit) | `lightcraft--windows-x86.msi` | `lightcraft--windows-x86-portable.zip` |
-Installers and executables are code-signed.
+Installers and executables are code-signed. The installer asks where to install (`C:\Program Files\LightCraft` by
+default; upgrades stay in the folder you chose) and ends on a page confirming LightCraft was installed, with an
+option to start it. For unattended installs: `msiexec /i lightcraft--windows-x64.msi /qn INSTALLFOLDER="D:\Apps\LightCraft\"`.
### macOS
diff --git a/docs/whats-new.md b/docs/whats-new.md
index a43ebfb2..b88d91ad 100644
--- a/docs/whats-new.md
+++ b/docs/whats-new.md
@@ -145,6 +145,10 @@
)
### Reliability
+- The Windows installer asks where to install LightCraft (Program Files by default; upgrades keep the folder you
+ chose) and ends on a page saying it was installed, with a "Launch LightCraft" box. It used to finish without a word,
+ so a successful install looked like nothing had happened (issues #18, #399). Silent installs (`/qn`, `/passive`)
+ show no dialogs and take `INSTALLFOLDER=...`.
- If the desktop app can't open its window (for example when no graphics device can be used), it now says so in a
message box that names the log file, instead of quitting without a trace (issue #260).
- On macOS, single-key shortcuts that appear in the menu bar now work: E, C, H, M, ⇧P, I, K, D, ratings 0–5,
diff --git a/packaging/windows/lightcraft.wxs b/packaging/windows/lightcraft.wxs
index 37510455..ce98a714 100644
--- a/packaging/windows/lightcraft.wxs
+++ b/packaging/windows/lightcraft.wxs
@@ -1,10 +1,13 @@
@@ -33,13 +36,133 @@
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
@@ -50,6 +173,7 @@
+
diff --git a/packaging/windows/package.ps1 b/packaging/windows/package.ps1
index dae31757..c45bf885 100644
--- a/packaging/windows/package.ps1
+++ b/packaging/windows/package.ps1
@@ -13,6 +13,8 @@
Needs: Rust (MSVC toolchain + the target), the Windows SDK (rc.exe, signtool.exe),
and WiX v5: dotnet tool install --global wix --version 5.0.2
+ The WiX UI and Util extensions (installer dialogs, "Launch LightCraft" on Finish) are added to
+ the global WiX extension cache by this script (wix extension add -g ..., needs network once).
.EXAMPLE
pwsh packaging/windows/package.ps1 -Arch x64
@@ -32,6 +34,29 @@ function Invoke-Native([string] $What, [scriptblock] $Block) {
if ($LASTEXITCODE -ne 0) { throw "$What failed with exit code $LASTEXITCODE" }
}
+# A 24-bit BMP of two flat colours: $SplitX pixels of $Left, then $Right (colours as R,G,B).
+# Used for the installer's side/banner bitmaps so the MSI ships no third-party artwork.
+function New-PanelBitmap([string] $Path, [int] $Width, [int] $Height, [int] $SplitX, [byte[]] $Left, [byte[]] $Right) {
+ $stride = [int][Math]::Ceiling($Width * 3 / 4) * 4
+ $row = New-Object byte[] $stride
+ for ($x = 0; $x -lt $Width; $x++) {
+ $c = if ($x -lt $SplitX) { $Left } else { $Right }
+ $row[$x * 3] = $c[2]; $row[$x * 3 + 1] = $c[1]; $row[$x * 3 + 2] = $c[0] # BMP pixels are B,G,R
+ }
+ $pixels = $stride * $Height
+ $ms = [IO.MemoryStream]::new()
+ $w = [IO.BinaryWriter]::new($ms)
+ $w.Write([byte]0x42); $w.Write([byte]0x4D) # 'BM'
+ $w.Write([uint32](54 + $pixels)); $w.Write([uint32]0); $w.Write([uint32]54)
+ $w.Write([uint32]40); $w.Write([int32]$Width); $w.Write([int32]$Height) # BITMAPINFOHEADER
+ $w.Write([uint16]1); $w.Write([uint16]24); $w.Write([uint32]0); $w.Write([uint32]$pixels)
+ $w.Write([int32]2835); $w.Write([int32]2835); $w.Write([uint32]0); $w.Write([uint32]0)
+ for ($y = 0; $y -lt $Height; $y++) { $w.Write($row) }
+ $w.Flush()
+ [IO.File]::WriteAllBytes($Path, $ms.ToArray())
+ $w.Dispose()
+}
+
# The version lives in one place: [workspace.package] version in the root Cargo.toml.
$Version = $env:LIGHTCRAFT_VERSION
if (-not $Version) {
@@ -91,10 +116,26 @@ Copy-Item (Join-Path $Bin 'lightcraft.exe'), (Join-Path $Bin 'lightcraft-cli.exe
& (Join-Path $PSScriptRoot 'sign.ps1') (Join-Path $Stage 'lightcraft.exe') (Join-Path $Stage 'lightcraft-cli.exe')
# ---- MSI ---------------------------------------------------------------------------------------
+# Extensions must match the WiX tool version (5.0.2, see release.yml). Re-adding is harmless.
+$WixVersion = '5.0.2'
+$WixExtensions = 'WixToolset.UI.wixext', 'WixToolset.Util.wixext'
+foreach ($ext in $WixExtensions) {
+ Invoke-Native "wix extension add $ext/$WixVersion" { wix extension add -g "$ext/$WixVersion" }
+}
+$ExtArgs = foreach ($ext in $WixExtensions) { '-ext'; "$ext/$WixVersion" }
+
+# Installer dialog bitmaps (WixUI sizes): a brand-blue side panel on the welcome/finish pages and
+# a plain white banner on the inner pages. Generated here, never committed.
+$UiDialogBmp = Join-Path $Stage 'ui-dialog.bmp'
+$UiBannerBmp = Join-Path $Stage 'ui-banner.bmp'
+New-PanelBitmap $UiDialogBmp 493 312 164 ([byte[]](0x4E, 0x7B, 0xFB)) ([byte[]](0xFF, 0xFF, 0xFF))
+New-PanelBitmap $UiBannerBmp 493 58 0 ([byte[]](0xFF, 0xFF, 0xFF)) ([byte[]](0xFF, 0xFF, 0xFF))
+
$Msi = Join-Path $Dist "lightcraft-$Version-windows-$Arch.msi"
Invoke-Native 'wix build' {
- wix build (Join-Path $PSScriptRoot 'lightcraft.wxs') -arch $Arch `
+ wix build (Join-Path $PSScriptRoot 'lightcraft.wxs') -arch $Arch -culture en-us @ExtArgs `
-d "Version=$MsiVersion" -d "BinDir=$Stage" -d "IconPath=$(Join-Path $Root 'assets\app-icon\lightcraft.ico')" `
+ -d "UiDialogBmp=$UiDialogBmp" -d "UiBannerBmp=$UiBannerBmp" `
-o $Msi
}
# wix writes its debug symbols (.wixpdb) next to the MSI; keep them out of the release assets.