shifathosn
/
pdfcraft
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Identity test: wait for the page's text before selecting it 

On a slow Windows runner the test selected text before the page had loaded,
which selects nothing, so no highlight was made and the author check failed
(seen on PR #59's CI). Settle rendering first, as the comment tests do.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
Brandon Thomas 2026-10-06 06:52:30 -04:00
parent fdfdc879d7
commit 19673084bd
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
crates/ui-egui/tests/identity.rs
View File

@ -35,8 +35,16 @@ fn the_identity_name_signs_new_comments_and_is_remembered() {
h.get_by_role_and_label(Role::TextInput, "Name on new comments").type_text("Grace Hopper");
h.run_steps(2);
assert_eq!(h.state().comment_prefs.author, "Grace Hopper");
// New comments carry it.
// New comments carry it. Wait for the page (and its text) to finish loading first: selecting
// text that hasn't loaded selects nothing, and no highlight is made (seen on slow CI runners).
h.state_mut().set_option("dialog", "none").unwrap();
for _ in 0..200 {
h.run_steps(2);
if !h.state().render_pending() {
break;
}
std::thread::sleep(std::time::Duration::from_millis(5));
}
h.state_mut().views[0].select_text(0, 4, 8);
assert!(h.state_mut().execute("comment.highlight"));
// Wait for the edit to land in the document (it applies on a later frame).