From 91dc8718b872f0d8ba26d1201823581bf1d85a97 Mon Sep 17 00:00:00 2001 From: bflatastic Date: Wed, 7 Oct 2026 09:52:19 +0700 Subject: [PATCH] Windows: register PrintCraft as a PDF handler, so it can be the default (#107) The MSI registered no file association. The only PrintCraft entry a user could pick in "Choose an app on your PC" was the advertised Start Menu shortcut, which Windows can't run as a file handler ("This app can't run on your PC"). The MSI now uses Windows' Default Programs registration: a PrintCraft.Document ProgID (open command, icon), .pdf OpenWithProgids, Applications\printcraft.exe (friendly name, supported types), and Capabilities\FileAssociations listed under RegisteredApplications. PrintCraft appears under "Open with" and in Settings > Default apps. It never takes over an existing default: .pdf's own default value is left alone, and the user chooses. Checked locally with WiX 5.0.2: the MSI builds, passes ICE validation (only the existing ICE61 note on same-version upgrades), and its Registry table holds exactly these values. Co-Authored-By: Claude Opus 5.5 --- packaging/windows/printcraft.wxs | 24 ++++++++++++++++++++++-- 1 file changed, 22 insertions(+), 2 deletions(-) diff --git a/packaging/windows/printcraft.wxs b/packaging/windows/printcraft.wxs index 388814d2..0bb390d0 100644 --- a/packaging/windows/printcraft.wxs +++ b/packaging/windows/printcraft.wxs @@ -4,8 +4,9 @@ wix build printcraft.wxs -arch x64 -d Version=1.2.3 -d BinDir=... -d IconPath=... -o out.msi - Per-machine install into Program Files, a Start Menu shortcut and an App Paths entry. Files - opened with PrintCraft arrive on its command line. + Per-machine install into Program Files, a Start Menu shortcut, an App Paths entry, and PrintCraft + registered as a PDF handler (offered under "Open with" and in Default apps, never forced as the + default). Files opened with PrintCraft arrive on its command line. --> + + + + + + + + + + + + + +