From 7b85af8785cbfcb2ca3cf39dedacffdd6c7b92b9 Mon Sep 17 00:00:00 2001 From: Brandon Thomas Date: Mon, 5 Oct 2026 17:04:57 -0400 Subject: [PATCH] Tests: full screen and the About dialog get their own tests (parity evidence) Both were marked shipped on the generic 'every registered command is implemented' test, which the honest assessment flagged. Full screen: the shortcut enters, Escape leaves, and the command toggles both ways. About: the dialog shows the running version. Co-Authored-By: Claude Opus 5.5 --- crates/ui-egui/tests/commands.rs | 25 +++++++++++++++++++++++++ parity/acrobat-features.toml | 4 ++-- 2 files changed, 27 insertions(+), 2 deletions(-) diff --git a/crates/ui-egui/tests/commands.rs b/crates/ui-egui/tests/commands.rs index a4f1bdde..899bc02d 100644 --- a/crates/ui-egui/tests/commands.rs +++ b/crates/ui-egui/tests/commands.rs @@ -198,3 +198,28 @@ fn the_shortcuts_dialog_lists_the_real_bindings() { h.get_by_label(if mac { "⇧⌘S" } else { "Ctrl+Shift+S" }); h.get_by_label("Save as"); } + +#[test] +fn full_screen_toggles_by_shortcut_and_command_and_escape_leaves() { + let mut h = harness(); + h.key_press_modifiers(Modifiers::COMMAND, Key::L); + h.run_steps(2); + assert!(h.state().full_screen, "⌘L / Ctrl+L enters full screen"); + h.key_press(Key::Escape); + h.run_steps(2); + assert!(!h.state().full_screen, "Escape leaves full screen"); + h.state_mut().execute("view.full_screen"); + h.run_steps(2); + assert!(h.state().full_screen); + h.state_mut().execute("view.full_screen"); + h.run_steps(2); + assert!(!h.state().full_screen, "the command toggles back"); +} + +#[test] +fn the_about_dialog_shows_the_running_version() { + let mut h = harness(); + h.state_mut().execute("help.about"); + h.run_steps(3); + h.get_by_label_contains(&format!("Version {}", env!("CARGO_PKG_VERSION"))); +} diff --git a/parity/acrobat-features.toml b/parity/acrobat-features.toml index a3f706eb..8785afc5 100644 --- a/parity/acrobat-features.toml +++ b/parity/acrobat-features.toml @@ -1070,7 +1070,7 @@ milestone = "M3" status = "shipped" commands = ["view.full_screen"] tools = [] -evidence = ["crates/ui-egui/tests/commands.rs::every_registered_command_is_implemented"] +evidence = ["crates/ui-egui/tests/commands.rs::full_screen_toggles_by_shortcut_and_command_and_escape_leaves"] notes = "" [[feature]] @@ -1682,7 +1682,7 @@ milestone = "M3" status = "shipped" commands = ["help.about"] tools = [] -evidence = ["crates/ui-egui/tests/commands.rs::every_registered_command_is_implemented"] +evidence = ["crates/ui-egui/tests/commands.rs::the_about_dialog_shows_the_running_version"] notes = "" [[feature]]