From f22b5d424bfe2607873c17e065a5e079766f8de8 Mon Sep 17 00:00:00 2001
From: Luis Araya <35828647+Totopo27@users.noreply.github.com>
Date: Sun, 11 Oct 2026 10:32:29 -0600
Subject: [PATCH] feat(macos): declare document icon file for PDFs in
 Info.plist (#910) (#933)

---
 packaging/macos/Info.plist.in | 2 ++
 xtask/src/gates.rs            | 1 +
 2 files changed, 3 insertions(+)

diff --git a/packaging/macos/Info.plist.in b/packaging/macos/Info.plist.in
index fad9c97e..cfc7d2d0 100644
--- a/packaging/macos/Info.plist.in
+++ b/packaging/macos/Info.plist.in
@@ -59,6 +59,8 @@
       <string>Editor</string>
       <key>LSHandlerRank</key>
       <string>Alternate</string>
+      <key>CFBundleTypeIconFile</key>
+      <string>PdfCraft</string>
       <key>LSItemContentTypes</key>
       <array><string>com.adobe.pdf</string></array>
       <key>CFBundleTypeExtensions</key>
diff --git a/xtask/src/gates.rs b/xtask/src/gates.rs
index 106f0e2c..4406a957 100644
--- a/xtask/src/gates.rs
+++ b/xtask/src/gates.rs
@@ -295,6 +295,7 @@ mod tests {
         assert!(pdf.contains("<string>com.adobe.pdf</string>"), "claim PDFs by UTI, not just extension/MIME");
         assert!(pdf.contains("<string>Editor</string>"), "PDF role stays Editor");
         assert!(pdf.contains("<string>Alternate</string>"), "rank stays Alternate: offered without taking over Preview");
+        assert!(pdf.contains("<key>CFBundleTypeIconFile</key>"), "declares document icon file for Finder");
     }
 
     // The bundle id must match the app id the binary uses; renames change both (#174).