shifathosn
/
photocraft
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

xtask i18n-coverage: read the deflated catalog! registry entries 

0c72d954 changed the LANGUAGES registry from include_str!("xx.tsv") to catalog!("xx"), so
`cargo xtask i18n-coverage` failed with "language `ja` has no include_str! catalog". Parse the
new form (the macro argument is the catalog's file stem).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
Brandon Thomas 2026-10-09 22:36:03 -04:00
parent e633d17a09
commit c78e72c0ec
1 changed files with 8 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
xtask/src/i18n_coverage.rs
View File

@ -94,12 +94,13 @@ fn registered_languages(source: &str) -> Result<Vec<Language>, String> {
let catalog = if code == "en" {
None
} else {
let marker = "include_str!(\"";
let start = block.find(marker).ok_or_else(|| format!("language `{code}` has no include_str! catalog"))? + marker.len();
// `catalog!("xx")` embeds `xx.tsv` (deflated by ui-egui's build.rs).
let marker = "catalog!(\"";
let start = block.find(marker).ok_or_else(|| format!("language `{code}` has no catalog! entry"))? + marker.len();
let rest = block.get(start..).ok_or_else(|| format!("language `{code}` has a malformed catalog path"))?;
let end = rest.find("\")").ok_or_else(|| format!("language `{code}` has a malformed catalog path"))?;
let file = rest.get(..end).ok_or_else(|| format!("language `{code}` has an invalid catalog path"))?;
let path = Path::new(file);
let file = format!("{}.tsv", rest.get(..end).ok_or_else(|| format!("language `{code}` has an invalid catalog path"))?);
let path = Path::new(&file);
if path.components().count() != 1 || path.extension().and_then(|ext| ext.to_str()) != Some("tsv") {
return Err(format!("language `{code}` has unsafe catalog path `{file}`"));
}
@ -482,9 +483,9 @@ mod tests {
fn registered_languages_and_report_are_stable() {
let registry = r#"
pub static LANGUAGES: [LangInfo; 3] = [
LangInfo { code: "zh", source: include_str!("zh.tsv") },
LangInfo { code: "en", source: "" },
LangInfo { code: "fr", source: include_str!("fr.tsv") },
LangInfo { code: "zh", source: catalog!("zh") },
LangInfo { code: "en", source: b"" },
LangInfo { code: "fr", source: catalog!("fr") },
];
impl LangInfo {}
"#;