From fee08b07b63de032c951d04fdd9a7fa7ec5b29c6 Mon Sep 17 00:00:00 2001 From: Tanish Manku Date: Wed, 7 Oct 2026 19:31:43 -0700 Subject: [PATCH] CI: craft-fonts run uses the Test step's exact build again (Linux runner out of disk since #800) (#955) #800 narrowed the craft-fonts test run to -p photocraft-text -p photocraft-ui-egui. A different package and feature selection resolves a different feature set (no --features heif), so cargo recompiled the whole dependency graph into the same target dir on top of the Test step's build, and test (ubuntu-latest) ran out of disk (No space left on device, linker bus error) on main and every PR. Back to cargo test --workspace --locked --features heif, which reuses the Test step's artifacts and rebuilds only the crates that read CRAFT_FONTS_DIR. The comment says why the selection must match. Co-authored-by: Claude Opus 5.5 --- .github/workflows/ci.yml | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 2b7f04c7..704f78d0 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -94,9 +94,11 @@ jobs: if: runner.os == 'Linux' run: cargo test -p photocraft-heif -p photocraft-codecs -p photocraft-io --locked - # The crates that use the optional craft-fonts input (crates/text/build.rs, and the UI's CJK - # font fallback), tested again with it, so the Japanese font tests that skip without it run - # here. Linux only. + # The same tests built with the optional craft-fonts input (crates/text/build.rs), so the + # Japanese font tests that skip without it run here. Linux only. Keep the exact `--workspace + # --features heif` of the Test step: any other package or feature selection resolves a + # different feature set, recompiles the whole dependency graph into the same target dir and + # runs the runner out of disk (as `-p photocraft-text -p photocraft-ui-egui` did after #800). - name: Check out craft-fonts if: runner.os == 'Linux' uses: actions/checkout@11d5960a326750d5838078e36cf38b85af677262 # v4 @@ -110,7 +112,7 @@ jobs: env: CRAFT_FONTS_DIR: ${{ github.workspace }}/craft-fonts CRAFT_FONTS_REQUIRED: "1" - run: cargo test -p photocraft-text -p photocraft-ui-egui --locked + run: cargo test --workspace --locked --features heif - name: Clippy run: cargo clippy --workspace --all-targets --locked --features heif -- -D warnings