fix(cli): start on Windows when USERPROFILE is empty (#2345)

* fix(cli): start on Windows when USERPROFILE is empty

Node's Windows home lookup throws ERR_SYSTEM_ERROR (uv_os_homedir ENOENT)
for an empty USERPROFILE instead of consulting the account profile. Incur
resolves the home while it is imported, so every command, including
`rea --version`, stopped with a raw stack trace before REA ran.

Treat the empty selection as unset in the launcher, before any runtime
import, and cover startup with a compiled-CLI regression.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(process): report no remaining time after a provider deadline fires

Node timers can fire while performance.now() is still a fraction of a
millisecond short of the monotonic deadline. ProviderStartupDeadline then
reported interruption "timeout" and an aborted signal while remainingMs()
returned ceil(0.x) = 1, so polling loops guarded by remainingMs() > 0
(Hopper and Ghidra startup) could run past an elapsed deadline, and the
real-timer test "aborts a bounded wait when its real monotonic deadline
expires" failed intermittently in CI (expected 1 to be 0).

Once the deadline's own timer has classified a timeout, report zero
remaining time. A deterministic regression test fires the timer with the
monotonic clock 0.4 ms short of the deadline.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: morluto <76467478+morluto@users.noreply.github.com>
Co-authored-by: Kaoru0822 <208281322+kaoru0822-kitauji@users.noreply.github.com>

src/process/ProviderDeadline.test.ts

@@ -179,3 +179,25 @@ it("releases the timer and listener on dispose with a pending wait", async () =>
     vi.useRealTimers();
   }
 });
+
+// Preserve the authored fractional-clock control while following the current
+// owning deadline's re-arm contract for an early native timer callback.
+it("reports zero after the re-armed deadline reaches a fractional early callback", async () => {
+  vi.useFakeTimers({ toFake: ["setTimeout", "clearTimeout"] });
+  const now = vi.spyOn(performance, "now").mockReturnValue(1_000);
+  const deadline = new ProviderStartupDeadline(40);
+  try {
+    now.mockReturnValue(1_039.6);
+    await vi.advanceTimersByTimeAsync(40);
+    expect(deadline.signal.aborted).toBe(false);
+    expect(deadline.remainingMs()).toBe(1);
+    now.mockReturnValue(1_040);
+    await vi.advanceTimersByTimeAsync(1);
+    expect(deadline.signal.aborted).toBe(true);
+    expect(deadline.interruption).toBe("timeout");
+    expect(deadline.remainingMs()).toBe(0);
+  } finally {
+    deadline.dispose();
+    vi.useRealTimers();
+  }
+});

src/process/ProviderDeadline.ts

@@ -79,6 +79,9 @@ export class ProviderStartupDeadline {
 
   /** Milliseconds still available to the next startup phase. */
   remainingMs(): number {
+    // Node timers can fire a fraction of a millisecond before the monotonic
+    // deadline, so an elapsed timer must not report time left to spend.
+    if (this.#interruption === "timeout") return 0;
     return Math.max(0, Math.ceil(this.#deadlineAt - performance.now()));
   }
 

tests/boundary/cli/emptyHomeStartup.test.ts

@@ -0,0 +1,32 @@
+import { readFile } from "node:fs/promises";
+
+import { expect } from "vitest";
+import { z } from "zod";
+
+import { createTestTempDirectory } from "../../fixtures/temporaryDirectory.js";
+import { cliTest } from "../../support/cli/cliFixture.js";
+
+const packageSchema = z.object({ version: z.string() });
+
+// Node's Windows home lookup throws for an empty USERPROFILE, so a dependency
+// that resolves the home during import used to stop every command there.
+cliTest("starts when the selected home is empty", async ({ cli }) => {
+  const { version } = packageSchema.parse(
+    JSON.parse(await readFile("package.json", "utf8")),
+  );
+  const cwd = await createTestTempDirectory("rea-empty-home-startup-");
+  const environment = { HOME: "", USERPROFILE: "" };
+
+  const reported = await cli.run({
+    arguments: ["--version"],
+    cwd,
+    environment,
+  });
+  expect(reported.stderr).toBe("");
+  expect(reported.exitCode).toBe(0);
+  expect(reported.stdout.trim()).toBe(version);
+
+  const help = await cli.run({ arguments: ["--help"], cwd, environment });
+  expect(help.stderr).not.toContain("uv_os_homedir");
+  expect(help.exitCode).toBe(0);
+});