From ece15ed6a18122f95e59d7d9f8bf9f0d3589f9f6 Mon Sep 17 00:00:00 2001
From: xin zhuang <65798732+1052326311@users.noreply.github.com>
Date: Tue, 13 Oct 2026 21:15:33 +0800
Subject: [PATCH] fix(electron): identify each unresolved scenario path (#2279)

Co-authored-by: morluto <76467478+morluto@users.noreply.github.com>
---
 .../cli/scenarioCliInputDiagnostics.test.ts   | 41 +++++++++++++++++
 tests/boundary/mcp/electronMcp.test.ts        | 46 +++++++++++++++++++
 2 files changed, 87 insertions(+)

diff --git a/tests/boundary/cli/scenarioCliInputDiagnostics.test.ts b/tests/boundary/cli/scenarioCliInputDiagnostics.test.ts
index bc98d9d9f..ae03568f4 100644
--- a/tests/boundary/cli/scenarioCliInputDiagnostics.test.ts
+++ b/tests/boundary/cli/scenarioCliInputDiagnostics.test.ts
@@ -1,3 +1,5 @@
+import { join } from "node:path";
+import { createTestTempDirectory } from "../../fixtures/temporaryDirectory.js";
 import { describe, expect } from "vitest";
 
 import { cliTest } from "../../support/cli/cliFixture.js";
@@ -62,3 +64,42 @@ describe("scenario CLI schema diagnostics", () => {
     });
   });
 });
+
+for (const field of [
+  "executable_path",
+  "application_path",
+  "application_root",
+] as const) {
+  cliTest(`names the unresolved Electron ${field}`, async ({ cli }) => {
+    const root = await createTestTempDirectory("rea-electron-path-");
+    const missing = join(root, "missing");
+    const result = await cli.run({
+      arguments: [
+        "capture-electron-scenario",
+        JSON.stringify({
+          executable_path: process.execPath,
+          application_path: root,
+          application_root: root,
+          actions: [],
+          [field]: missing,
+        }),
+        "--json",
+      ],
+      environment: { REA_LOG_LEVEL: "silent" },
+    });
+    expect(result.exitCode).toBe(1);
+    expect(result.json).toMatchObject({
+      code: "invalid_request",
+      details: {
+        issues: [
+          {
+            path: [field],
+            reason: "invalid_value",
+            message: expect.stringContaining("ENOENT"),
+          },
+        ],
+      },
+    });
+    expect(JSON.stringify(result.json)).toContain(missing);
+  });
+}
diff --git a/tests/boundary/mcp/electronMcp.test.ts b/tests/boundary/mcp/electronMcp.test.ts
index fef9839aa..72d9fdaf6 100644
--- a/tests/boundary/mcp/electronMcp.test.ts
+++ b/tests/boundary/mcp/electronMcp.test.ts
@@ -471,3 +471,49 @@ it("exposes the target-free static JavaScript application workflow", async () =>
 const evidenceFor = (value: unknown) => {
   return parseEvidence(value);
 };
+
+it("reports every unresolved Electron path without starting a provider", async () => {
+  const root = await createTestTempDirectory("rea-electron-invalid-paths-");
+  const capture = vi.fn();
+  const session = createTestBinarySession(() => {
+    throw new Error("must not start");
+  });
+  const server = createServer(
+    { kind: "session", session },
+    {
+      electronActiveObservation: {
+        capture,
+        identity: () => ({ id: "test", name: "test", version: "1" }),
+      },
+    },
+  );
+  const client = new Client({ name: "electron-path-test", version: "1" });
+  const [clientTransport, serverTransport] =
+    InMemoryTransport.createLinkedPair();
+  resources.push(client, server, session);
+  await server.connect(serverTransport);
+  await client.connect(clientTransport);
+  const fields = ["executable_path", "application_path", "application_root"];
+  const result = await client.callTool({
+    name: "capture_electron_scenario",
+    arguments: {
+      ...Object.fromEntries(fields.map((field) => [field, join(root, field)])),
+      actions: [],
+    },
+  });
+  expect(result.isError).toBe(true);
+  expect(parseMcpToolError(result)).toMatchObject({
+    error: {
+      code: "invalid_request",
+      details: {
+        issues: fields.map((field) => ({
+          path: [field],
+          reason: "invalid_value",
+          message: expect.stringContaining("ENOENT"),
+        })),
+      },
+    },
+  });
+  expect(capture).not.toHaveBeenCalled();
+  await client.ping();
+});